Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to AdSupport framework? #4

Closed
sjmadsen opened this issue Aug 28, 2020 · 3 comments
Closed

Remove references to AdSupport framework? #4

sjmadsen opened this issue Aug 28, 2020 · 3 comments

Comments

@sjmadsen
Copy link
Contributor

With Apple further restricting apps that track users in iOS 14, I'd like to see a version of this framework that removed any references to AdSupport or the IDFA (identifier for advertisers). The "upstream" repo that this one is based on has done this for their current 4.x release (see this pull request), allowing apps that want to collect the IDFA to provide it, rather than having the framework itself make those calls into AdSupport.

How do PostHog iOS users feel about such a change? I'm happy to make the changes and create a PR if there is interest.

@jamesefhawkins
Copy link

Hey @sjmadsen , sorry for the slow response here.

I think this makes total sense as a PR if it's something you'd use and then wouldn't mind sharing. I imagine functionality-wise we should have:

  • enabling apps that do not want ad tracking to pass App Store guidelines in certain categories while still allowing apps that do ad tracking to continue to function.
  • to put a paragraph just to explain how to do the above in here

@sjmadsen
Copy link
Contributor Author

sjmadsen commented Sep 8, 2020

I'll get a PR together in the next few days.

@mariusandra
Copy link
Contributor

This PR is now merged and version 1.1.0 of the library is out! Thanks again @sjmadsen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants