Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create ctor overloads for better Java DX #148

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jun 28, 2024

💡 Motivation and Context

https://posthog.com/questions/setup-using-android-java-project

💚 How did you test it?

// PostHogAndroidConfig config = new PostHogAndroidConfig("key");
// PostHogAndroidConfig config = new PostHogAndroidConfig("key", "host");
// PostHogAndroidConfig config = new PostHogAndroidConfig("key", "host", true);
... etc using a Java file

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team June 28, 2024 11:47
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@marandaneto marandaneto merged commit f934b9a into main Jun 28, 2024
5 checks passed
@marandaneto marandaneto deleted the chore/java-dx branch June 28, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants