Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

Disable plugins after they fail to load enough times / Retry loading plugins? #279

Closed
mariusandra opened this issue Mar 24, 2021 · 2 comments
Assignees

Comments

@mariusandra
Copy link
Collaborator

This my dev EE console every time I start it:

[MAIN] βœ… Kafka consumer connected!
[__14] πŸ”Œ Loaded plugin "MaxMind GeoIP" (organization 01778ae6-967a-0000-449a-270bb4205419)
[MAIN] βœ… Kafka consumer joined group clickhouse-ingestion!
[MAIN] βœ… Connected to Redis!
[MAIN] πŸš€ All systems go.
[__15] πŸ”Œ Loaded plugin "MaxMind GeoIP" (organization 01778ae6-967a-0000-449a-270bb4205419)
[__16] πŸ”Œ Loaded plugin "MaxMind GeoIP" (organization 01778ae6-967a-0000-449a-270bb4205419)
[__15] ⚠️ Failed to load plugin "Gitlab aasd" (organization 01778ae6-967a-0000-449a-270bb4205419)
[__16] ⚠️ Failed to load plugin "Gitlab aasd" (organization 01778ae6-967a-0000-449a-270bb4205419)
[__14] ⚠️ Failed to load plugin "Gitlab aasd" (organization 01778ae6-967a-0000-449a-270bb4205419)
[__14] ⚠️ Failed to load plugin "GitLab Release Tracker" (organization 01778ae6-967a-0000-449a-270bb4205419)
[__15] ⚠️ Failed to load plugin "GitLab Release Tracker" (organization 01778ae6-967a-0000-449a-270bb4205419)
[__16] ⚠️ Failed to load plugin "GitLab Release Tracker" (organization 01778ae6-967a-0000-449a-270bb4205419)

Right now if a plugin fails during initialisation, we'll just try again next time the server restarts. It might make sense to punish plugins that fail on boot by disabling them. Perhaps with some retry strategy?

Somewhat related to #273 and #72

Does not seem urgent right now, just documenting.

@mariusandra
Copy link
Collaborator Author

Here's an example of a plugin that fails in a different way: https://sentry.io/organizations/posthog/issues/2375532863/?project=5592816&query=is%3Aunresolved&statsPeriod=14d

After a few of these the plugin should somehow be taken out of the pipeline.

@yakkomajuri
Copy link
Contributor

#380 fixed this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants