You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have encountered an issue with the Popup Maker plugin where popups intended to display randomly are not appearing as expected. Upon investigation, we identified that the root cause of this issue is a comparison operation between string and integer values, which prevents the code from entering the necessary conditional branch to execute the random popup display logic.
Configure the Popup Maker plugin to display popups randomly in "Simple Custom CSS and JS".
I create three popups I want to show randomly.
Trigger the condition that should display each popups.
Observe that the popup does not appear.
Expected Behavior:
Randomly configured popups should appear when their specified conditions are met.
Actual Behavior:
Popups configured to display randomly do not appear due to the failure of a conditional check caused by comparing a string to an integer.
Hi, contributors
I have encountered an issue with the Popup Maker plugin where popups intended to display randomly are not appearing as expected. Upon investigation, we identified that the root cause of this issue is a comparison operation between string and integer values, which prevents the code from entering the necessary conditional branch to execute the random popup display logic.
I checked below document.
https://docs.wppopupmaker.com/article/313-a-b-test-or-randomly-display-popups
Steps to Reproduce:
Expected Behavior:
Randomly configured popups should appear when their specified conditions are met.
Actual Behavior:
Popups configured to display randomly do not appear due to the failure of a conditional check caused by comparing a string to an integer.
Below ID value is string.
ID = $this.popmake('getSettings').id;
Proposed Solution:
The issue can be resolved by converting the string value to an integer before performing the comparison.
e.g.
Additional Information:
Popup maker Version: 1.18.2
Browser(s) Tested: Chrome
WordPress Version: 6.4.3
Simple Custom CSS and JS: 3.46
May I create pull request above issue?
The text was updated successfully, but these errors were encountered: