Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a composed message has a content ID #26

Merged
merged 5 commits into from
Jul 17, 2019
Merged

a composed message has a content ID #26

merged 5 commits into from
Jul 17, 2019

Conversation

breitman
Copy link
Collaborator

No description provided.

@breitman breitman requested a review from hallettj July 12, 2019 19:43
packages/main/src/compose/edit.test.ts Show resolved Hide resolved
packages/main/src/compose/edit.test.ts Show resolved Hide resolved
packages/main/src/compose/newConversation.test.ts Outdated Show resolved Hide resolved
packages/main/src/compose/reply.test.ts Show resolved Hide resolved
@breitman breitman requested a review from hallettj July 16, 2019 14:31
Copy link
Contributor

@hallettj hallettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I restarted the tests, because I cannot reproduce the test error locally.

@hallettj
Copy link
Contributor

Oh, the tests are failing after merging changes in this PR with master. Please merge from master and fix the error before merging.

@breitman breitman requested a review from hallettj July 17, 2019 15:20
Copy link
Contributor

@hallettj hallettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@breitman breitman merged commit a11bf9d into master Jul 17, 2019
@breitman breitman deleted the BR/ContentID branch July 17, 2019 16:33
@hallettj
Copy link
Contributor

hallettj commented Nov 3, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hallettj
Copy link
Contributor

hallettj commented Nov 4, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants