Br/reply to #17
Br/reply to #17
Conversation
There was a problem hiding this comment.
I appreciate all of the effort you are putting into this feature! I know that the work has been complicated; I'm pleased with your persistence.
Yes, the name for some addresses will be null. That is because I have not added support for setting a name for an account, so messages sent from Poodle do not have names in the from address.
In the future I would like you to make pull request titles more descriptive. It's a good habit because descriptive titles help code reviewers to understand what they are looking at, and pull requests form a historical record.
There are merge conflicts - you will need to merge changes from master and resolve those conflicts.
|
I'm seeing a number of unused variable warnings from eslint. Please make a habit of using the "organize imports" feature in VS Code to remove unused imports, and to put import lines into a consistent order. And if you have not already done so it would be helpful to configure your editor to display eslint warnings. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
In test file, the 'from' field says name is null. Not sure why that is, but I matched it in the expect block to let the test pass. It must be due to the beforeEach block that adds the same account without including a name field. I will change it if needed, but I am pretty sure this fix is working correctly.