Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.1.1 dist cannot be used as asset #50

Closed
hatched opened this issue Nov 13, 2015 · 2 comments
Closed

4.1.1 dist cannot be used as asset #50

hatched opened this issue Nov 13, 2015 · 2 comments
Labels
bug

Comments

@hatched
Copy link

hatched commented Nov 13, 2015

We aren't able to use 4.1.1 because we have index.js being included directly in an application as an asset. It fails with a syntax error because global is not defined. I'd issue a PR but I'm not entirely sure when or why global would be defined.

Issue was introduced here: #48

Using React 0.14.x

Workaround: downgrade to 4.1.0
@Pomax
Copy link
Owner

Pomax commented Nov 14, 2015

Hm, looking at the code the global var seems to have become unbound. That's not very useful. Thanks for letting me know, I'll try to fix that asap.

@Pomax Pomax added the bug label Nov 14, 2015
@Pomax
Copy link
Owner

Pomax commented Nov 18, 2015

marking as duplicate of #51

@Pomax Pomax closed this as completed Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pomax @hatched