Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.split(0, 0) returns left and right curves #177

Open
orange4glace opened this issue Feb 14, 2022 · 1 comment · May be fixed by #211
Open

.split(0, 0) returns left and right curves #177

orange4glace opened this issue Feb 14, 2022 · 1 comment · May be fixed by #211
Labels
bug enhancement

Comments

@orange4glace
Copy link

First, thanks for the great library! This is awesome :> It helps me a lot.

.split(0, 0) returns what .split(0) returns, which has left and right curves.
I think .split(0, 0) should return single curve with zero length since it explicitly splits between 0 and 0.
@Pomax
Copy link
Owner

Pomax commented Feb 14, 2022

Hmm, good point, But I'd probably make split(a,b) throw on a===b instead, as there isn't anything to return in that case, so whatever code is getting invoked almost certainly has a bug.

LeoDog896 added a commit to LeoDog896/bezierjs that referenced this issue Oct 31, 2023
@LeoDog896
fix: Pomax#177
1f5b53b
@LeoDog896 LeoDog896 linked a pull request Oct 31, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: throw error on split(a, b) iff a === b LeoDog896/bezierjs
2 participants
@Pomax @orange4glace