Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Crisper ignores crossorigin attribute on script tag #48

Open
vdonich opened this issue Feb 16, 2017 · 3 comments
Open

Crisper ignores crossorigin attribute on script tag #48

vdonich opened this issue Feb 16, 2017 · 3 comments
Labels
Source: Hooli

Comments

@vdonich
Copy link

vdonich commented Feb 16, 2017

Running crisper --source file.html --html c.html --js c.js over a file that contains script with crossorigin attribute produces html code without crossorigin attribute.

Source:

<html>
  <body>
    <script crossorigin="anonymous">
      (function() {
          'use strict';
          console.log('foo');
      });
    </script>
  </body>
</html>

Resulting html:

<html><head><script src="c.js" defer=""></script>
    <meta charset="UTF-8">
@justinfagnani
Copy link

We can try to get a fix in for this soon, but Cripser is going to be deprecated in favor of the Polymer CLI, and likely a build option to externalize scripts. cc @FredKSchott for context

@vdonich
Copy link
Author

vdonich commented Feb 17, 2017

Thanks, I'll check if Polymer CLI behavior is different in this aspect and file a feature request if needed.

@justinfagnani
Copy link

We're still working on getting the CLI to do exactly what Cripser does, so it may be fast to fix this in the short term. Just a heads up for longer term.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Source: Hooli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinfagnani @vdonich