Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding scroll event listener as passive #52

Open
SamEdwards-1 opened this issue Dec 21, 2020 · 0 comments
Open

Consider adding scroll event listener as passive #52

SamEdwards-1 opened this issue Dec 21, 2020 · 0 comments

Comments

@SamEdwards-1
Copy link

Description

I've been doing a lot of performance profiling and the scroll does seem a bit smoother when using passive event listeners. Marking an event listener as passive just means that you are promising not to cancel the event, and as best I can tell this component never does so.

Does anyone know if there is a good reason not to do this that is eluding me? If not I'd be happy to contribute a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant