Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD loader only injected in entrypoint #647

Closed
LarsDenBakker opened this issue Aug 15, 2018 · 2 comments
Closed

AMD loader only injected in entrypoint #647

LarsDenBakker opened this issue Aug 15, 2018 · 2 comments
Labels

Comments

@LarsDenBakker
Copy link
Contributor

LarsDenBakker commented Aug 15, 2018

The AMD loader is only ever injected in the entry point due to this check: https://github.com/Polymer/tools/blob/master/packages/build/src/optimize-streams.ts#L223

This fails to account for situations where modules are loaded from a HTML import, but not the entrypoint.

I'm not sure if this can be fixed easily, as the current method is an easy way to ensure the loader is only injected once ever per project. An easy workaround is to add an empty module to the index.html, which will trigger the injection. A module correct way is to perhaps add a configuration option? Along with #495 a lot of the checks are es-module only oriented.

@stale
Copy link

stale bot commented Mar 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 4, 2020
@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant