Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addPushManifest treats app dependencies as siblings #433

Closed
keanulee opened this issue Jun 4, 2018 · 4 comments
Closed

addPushManifest treats app dependencies as siblings #433

keanulee opened this issue Jun 4, 2018 · 4 comments

Comments

@keanulee
Copy link
Contributor

keanulee commented Jun 4, 2018

Shop#master (Polymer 2.0) uses the es6-unbundled preset which uses the addPushManifest build configuration. Today, running polymer build generates a push-manifest.json that references dependencies as siblings:

{
  "src/shop-app.html": {
    "../polymer/polymer-element.html": {
      "type": "document",
      "weight": 1
    },

Expected

Previously, they are correctly referenced as files within bower_components:

{
  "src/shop-app.html": {
    "bower_components/polymer/polymer-element.html": {
      "type": "document",
      "weight": 1
    },

This regressed sometime during the run-up to the Polymer 3.0 release.

@d4l3k
Copy link

d4l3k commented Jun 11, 2018

yarn global add [email protected] works correctly.

@aomarks
Copy link
Member

aomarks commented Jun 20, 2018

This should be fixed in polymer-cli 1.7.4 released yesterday.

@aomarks aomarks closed this as completed Jun 20, 2018
@d4l3k
Copy link

d4l3k commented Jun 20, 2018

Nice! Thanks @aomarks!

@aomarks
Copy link
Member

aomarks commented Jun 21, 2018

Hi @d4l3k :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants