Ensure template given to ShadyCSS is the one rendered by lit-html #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2018 10:07
This ensures ShadyCSS can update the style in the template that will be rendered by lit-html. ShadyCSS needs to do this, for example, when the set of properties changes in any `@apply`'s. Fixes lit/lit-element#117
src/lib/shady-render.ts
Outdated
| shadyRenderSet.add(scopeName); | ||
| // Move styles out of rendered DOM and store. | ||
| const styleFragment = document.createDocumentFragment(); | ||
| Array.from(fragment.querySelectorAll('style')).forEach((s: Element) => { |
There was a problem hiding this comment.
I'd use a for loop... not a lot of reason to allocate the array.
src/lib/shady-render.ts
Outdated
| }); | ||
| // Remove styles from nested templates in this scope and put them | ||
| // into the "root" template passed in as `template`. | ||
| removeStylesFromLitTemplates(scopeName); |
There was a problem hiding this comment.
could this be renamed to be more clear that it's moving styles?
There was a problem hiding this comment.
It is named correctly, but the comment is for the next two lines. Moved the comments to make more clear.
src/lib/shady-render.ts
Outdated
| // Remove styles from nested templates in this scope and put them | ||
| // into the "root" template passed in as `template`. | ||
| removeStylesFromLitTemplates(scopeName); | ||
| insertNodeIntoTemplate( |
There was a problem hiding this comment.
Is this the big change here? I'm having a little bit of a hard time seeing the change in behavior.
There was a problem hiding this comment.
Added a comment. Yes, the key bit is that we hand ShadyCSS a template that will actually be rendered by lit-html. This way it can update the style inside it and affect subsequent lit-html renderings.
dfreedm
approved these changes
Sep 13, 2018
|
@justinfagnani PTAL |
justinfagnani
approved these changes
Sep 13, 2018
neuronetio
pushed a commit
to neuronetio/lit-html
that referenced
this pull request
Dec 2, 2019
…t#502) This ensures ShadyCSS can update the style in the template that will be rendered by lit-html. ShadyCSS needs to do this, for example, when the set of properties changes in any `@apply`'s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures ShadyCSS can update the style in the template that will be rendered by lit-html. ShadyCSS needs to do this, for example, when the set of properties needed in any
@applychanges.Fixes lit/lit-element#117