Handle case-sensitive attributes like viewBox. #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
force-pushed
the
viewbox
branch
2 times, most recently
from
2eabf98 to
8829761
Compare
|
Looking good so far! |
kevinpschaaf
approved these changes
Jun 22, 2018
src/test/lit-html_test.ts
Outdated
| assert.equal( | ||
| stripExpressionDelimeters(container.innerHTML), | ||
| '<svg viewBox="0 0 100 100"></svg>'); | ||
| }); |
There was a problem hiding this comment.
For Edge test to pass, apparently need to strip the extra xmlns attribute when asserting. And they helpfully render the innerHTML as a self-closing tag, apparently. Sigh.
expected '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100" />' to equal '<svg viewBox="0 0 100 100"></svg>'
Maybe just change it to
assert.match(stripExpressionDelimeters(container.innerHTML), /viewBox="0 0 100 100"/);
jridgewell
suggested changes
Jun 22, 2018
src/lit-html.ts
Outdated
| // so that on XML nodes with case-sensitive getAttribute() we can | ||
| // still find the attribute, which will have been lower-cased by | ||
| // the parser. | ||
| const attributeLookupName = /^[a-zA-z-]*$/.test(attributeNameInPart) ? |
There was a problem hiding this comment.
The A-z looks like a bug.
There was a problem hiding this comment.
Definitely. Nice catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374