Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Closure Compiler and #470 #476

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Fix issue with Closure Compiler and #470 #476

merged 1 commit into from
Jan 24, 2019

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Jan 24, 2019

No description provided.

@dfreedm dfreedm requested a review from sorvell January 24, 2019 01:04
@dfreedm dfreedm changed the title Fix issue with Closure Compiler and PR 470 Fix issue with Closure Compiler and #470 Jan 24, 2019
justinfagnani
justinfagnani approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh Closure. We should have a Closure built/test step for pre-flighting releases.

@dfreedm
Copy link
Member Author

dfreedm commented Jan 24, 2019

@justinfagnani We'd need a whole example app, as the library compiles cleanly.

@dfreedm dfreedm merged commit 33c4794 into master Jan 24, 2019
@dfreedm dfreedm deleted the jscompiler-finalize-fix branch January 24, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@sorvell sorvell sorvell approved these changes

@rictic rictic rictic approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dfreedm @rictic @sorvell @justinfagnani @googlebot