-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix closure compiler renaming safety. #465
Conversation
JSCompiler_renameProperty can't be exported from a module, it's a global. If it's exported then jscompiler doesn't treat it as special, it's just a normal function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please update changelog
Currently i'm getting this error when compiling lit element 2.2.1 with the closure compiler 20190929
|
What flags are you passing to closure compiler? Are you transforming lit-element using clutz? |
This is the list of flags for the closure compiler:
Both lit-element and lit-html are installed using npm, and the .js files are included. Currently there is no conversion between TS and JS using clutz or tsickle. |
JSCompiler_renameProperty can't be exported from a module, it's a global. If it's exported then jscompiler doesn't treat it as special, it's just a normal function.