[docs] Update docs to reflect #454 change to remove accessor wrapping #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we no longer wrap existing accessors, the language and example in #accessors-custom is updated to indicate the user must manually call `requestUpdate`. In addition, since `noAccessor` is _only_ needed now in a pretty esoteric case (extending a superclass and changing metadata for a declared property _that also has a custom accessor_), the code example in that section is simplified.
ghost
suggested changes
Jan 18, 2019
justinfagnani
approved these changes
Jan 18, 2019
Co-Authored-By: katejeffreys <[email protected]>
Co-Authored-By: katejeffreys <[email protected]>
ghost
changed the title
|
@kevinpschaaf pls see #489 for some changes i wanted to add to this. If it works better, I can make a PR to master after this is merged |
ghost
self-assigned this
|
@katejeffreys I think you can just merge #489 into here, then merge this. |
[docs] Code samples for accessors with subclassing && tidy up doc
ghost
approved these changes
Feb 4, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer wrap existing accessors, the language and example in #accessors-custom is updated to indicate the user must manually call
requestUpdate.In addition, since
noAccessoris only needed now in a pretty esoteric case (extending a superclass and changing metadata for a declared property that also has a custom accessor), the code example in that section is simplified.Reference Issue
Docs update for #454