Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP 1.0.0 #173

Open
terricain opened this issue Jul 7, 2018 · 3 comments
Open

AMQP 1.0.0 #173

terricain opened this issue Jul 7, 2018 · 3 comments

Comments

@terricain
Copy link

I have a need for v1.0.0 (sadly I have a requirement to use ActiveMQ and am using STOMP atm :/)

I've got a really simple example I hacked up that currently connects, sends a header packet and does SASL login.

Once I've implemented enough for some basic produce/consume, how woud I go about PRing this considering v1.0.0 is drastically different to v0.9.1

@dzen
Copy link
Contributor

dzen commented Jul 16, 2018

Hello @terrycain,

I did'nt read any specs about AMQP 1.0. When implementing a first version, I was focused on 0.9.1.
Feel free to start a PR, and explain how you would go for a first version ?

In a first try, I would like to focus on the API :)

@gmr
Copy link

gmr commented Jan 17, 2019

AMQP 1.0 is a different beast all-together. You'd probably be better off making an aioamqp1 as a separate library given the foundational differences. It's not an evolution of the 0.x AMQP protocol.

@dzen
Copy link
Contributor

dzen commented Jan 18, 2019

Hello @gmr, thanks for also having a look on this project ;)

the lib can also have two endpoints, depending on the selection of the desired protocol.
Plus, since we now depends on pamp for the protocol layer, it would be a nice addition to pamqp wouldn't be ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants