Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build]: Fix build on Mac OS X, both intel and Arm architectures. #107

Closed
appetrosyan opened this issue Nov 9, 2023 · 3 comments · Fixed by #108
Closed

[build]: Fix build on Mac OS X, both intel and Arm architectures. #107

appetrosyan opened this issue Nov 9, 2023 · 3 comments · Fixed by #108

Comments

@appetrosyan
Copy link
Contributor

This is a placeholder issue for fixing PolyChord on Mac OS; while this might not be a high priority yet, not being able to test out theories on a mac environ is a problem.

This is going to involve fixing a few flags and un-resolving a few symlinks that lie. Namely the linker on Mac OS is not GNU LD, which causes the issue with the compiler flag ld: unknown options: -commons.

There are other issues which make the installation sub-optimal, so the PR shall be accompanied by a thorough modification of the README to reflect those changes.

@appetrosyan
Copy link
Contributor Author

After a bit of digging, I think it can be simply disabled on Mac OS X. It would cause a performance degradation, but that's inevitable on a portable device.

@appetrosyan
Copy link
Contributor Author

Actually, this is no longer necessary for FORTRAN programs

HDFGroup/hdf5#3571

I'll open a PR to fix

@appetrosyan
Copy link
Contributor Author

#104 Has a true fix. It should be reflected in the Readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant