Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Set round end block to None on evaluation fail #426

Open
wants to merge 1 commit into
base: 10-24-eth_compat._tests
Choose a base branch
from

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 30, 2024

Why?

  • All rounds that don't have an end depending on time, should have a None end. This includes FundingSuccessful, FundingFailed, all Settlement states, and all Migration states.

Testing?

  • No new tests needed since its something affecting the UI

Copy link
Contributor Author

JuaniRios commented Oct 30, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios requested review from Lederstrumpf, lrazovic and vstam1 and removed request for Lederstrumpf October 30, 2024 15:00
@JuaniRios JuaniRios marked this pull request as ready for review October 30, 2024 15:00
@JuaniRios JuaniRios changed the title Set round end block to None on evaluation fail 🔧 Set round end block to None on evaluation fail Oct 30, 2024
Copy link

graphite-app bot commented Oct 30, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (10/30/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant