Manitoba Renters Tax Credit #423
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PolicyEngine#419 Tests to be done
YiweiJ
reviewed
Aug 15, 2023
...ine_canada/parameters/gov/provinces/mb/tax/income/credits/renters_tax_credit/age_amount.yaml
Show resolved
Hide resolved
YiweiJ
reviewed
Aug 15, 2023
...parameters/gov/provinces/mb/tax/income/credits/renters_tax_credit/applicable_percentage.yaml
Show resolved
Hide resolved
YiweiJ
reviewed
Aug 15, 2023
...ne_canada/parameters/gov/provinces/mb/tax/income/credits/renters_tax_credit/base_amount.yaml
Show resolved
Hide resolved
YiweiJ
reviewed
Aug 15, 2023
...e_canada/parameters/gov/provinces/mb/tax/income/credits/renters_tax_credit/credit_value.yaml
Show resolved
Hide resolved
YiweiJ
reviewed
Aug 15, 2023
...gine_canada/parameters/gov/provinces/mb/tax/income/credits/renters_tax_credit/max_value.yaml
Show resolved
Hide resolved
YiweiJ
reviewed
Aug 15, 2023
...canada/parameters/gov/provinces/mb/tax/income/credits/renters_tax_credit/months_in_year.yaml
Show resolved
Hide resolved
| "months_living_in_rentals", period | ||
| ) | ||
|
|
||
| renters_tax_credit_amount = ( |
There was a problem hiding this comment.
Suggested change
| renters_tax_credit_amount = ( | |
| return ( |
| ) | ||
|
|
||
| age_eligible_credit = age_eligible * ( | ||
| (p.base_amount - max_amount_allowed) / p.months_in_year |
There was a problem hiding this comment.
use mask for dividing by 0
There was a problem hiding this comment.
we assume that 12 months have been rented - dont need this condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #419
Tests to be done
awaits issue#418 to be approved