Improve testing #2021
Draft
Improve testing #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anth-volk
force-pushed
the
fix/improved-testing
branch
from
3955af4 to
b9ab0e7
Compare
nikhilwoodruff
approved these changes
Nov 27, 2024
|
@nikhilwoodruff My understanding is that we already do: the |
|
Per discussion with @nikhilwoodruff, I'll be cutting a few tests out of this later today. Also need to rebase. |
anth-volk
force-pushed
the
fix/improved-testing
branch
from
419fc0d to
8a010f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2015
Partially fixes #2013 (some tests will need to be broken up into relevant files)
Fixes #2007
Fixes #1357
Inspired by #2010 (a regression introduced by #2006), this PR creates a new testing structure for economy-wide simulations. The aim is to make it simple to test that a series of common reform impacts (e.g., modifying the federal income tax rate) still runs and returns values within reason for certain key measures. This does not compare outputs with country packages (that's open as #2017, but it's unclear if its likely slow pace would justify writing it).
This also begins to move toward a more concise testing folder structure, whereby integration tests (any that hit use the
rest_clientPytest fixture to simulate an endpoint hit, then check its response) are distinct from unit tests. A few tests are either also being modified in an open PR or would need to be subdivided to match the internal file structure, so they've been relegated to a temporaryto_be_refactoredfolder.