-
-
Notifications
You must be signed in to change notification settings - Fork 2
Extend mask function for DataFrames #74
Comments
Also, would you mind if I added an optional I also like how it allows to plot the layer with occupied sites with a background that is not on the colour scale, as on my richness figures. It enhances the difference between sites with few occurrences and no occurrences at all. Something like this: plot(backgroundlayer, c = :lightgrey)
plot!(occurrencelayer, c = :viridis) |
It all makes sense to me, go ahead! |
BUT make sure it works with all types. Most of the bugs I've fixed recently where because we assumed the data would be floating point, and it's not always true. Maybe a mask function for dataframes, and then the documentation mentions |
Good point, I'll see about it. I think |
I think I would like it better to have replace! outside - that's one fewer argument in the function, and it makes people think about whether they really want to remove the 0. |
As soon as #75 is merged (in a minute...), I'll tag a new release with a |
Love the new
mask
function @tpoisot ! It will be incredibly useful.I think it would be nice if it worked on
DataFrames
too, not just onGBIFrecords
elements. That would be in line with the previousDataFrames
integration I've added, where I mostly mimicked the features from theGBIF
integration so that both can be used in a similar way.I created this function for my project a while ago and I think it works well enough. I'll update it to be similar to
mask
and add it in a PR, if you agree.The text was updated successfully, but these errors were encountered: