[#47] Adding filesystem support for save_df #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauglertodd
force-pushed
the
tbg/47
branch
3 times, most recently
from
d47af0c
to
11c3f24
Compare
timkpaine
requested changes
Oct 23, 2024
raydar/task_tracker/task_tracker.py
Outdated
| path: Optional[str] = None, | ||
| enable_perspective_dashboard: bool = False, | ||
| ): | ||
| def __init__(self, name: str, namespace: str, enable_perspective_dashboard: bool = False, filesystem: Type[fs.FileSystem] = fs.LocalFileSystem): |
There was a problem hiding this comment.
should this take an instance, otherwise how would you pass args to e.g. fs.S3FileSystem?
There was a problem hiding this comment.
\we've seen some issues with serializing certain filesystem objects - the alternative is default construction of a filesystem, which you can toggle through env variables. We could probably just take like a filesystem_kwargs=dict() parameter too, I don't have strong feelings about this
gauglertodd
force-pushed
the
tbg/47
branch
2 times, most recently
from
032e423
to
0558819
Compare
timkpaine
changed the title
timkpaine
changed the title
timkpaine
requested changes
Oct 24, 2024
... Signed-off-by: Todd Gaugler <[email protected]> ... ... . ...
timkpaine
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to some requests to allow for better
save_dffunctionality, specifically saving the internal dataframe to cloud storage rather than saving to local path.I'll play around with this approach and write some tests.
fixes #47