-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing py.typed to indicate native typing support #66
Comments
Thank you for suggestion however I do not think it is necessary. Our library is only imported in env.py file which is rarely checked by mypy (correct me if I am wrong) |
Well, mypy checks whatever you ask it to check. I prefer to check everything I can, and without this |
Pretty much this ☝🏻 Without the py.typed file (which is just an empty file in your repo, an indicator), I have to explicitly add this library in the mypy exclude list. It looks like you already add type definitions to your lib, so the only thing to worry about is adding this file and making sure it is shipped in the final package. |
These changes are shipped in |
what.
Since you're declaring types in your codebase, you should add the
py.typed
file to the repository (under thealembic_postgresql_enum
directory) and include it in the distributed package.This is so that people don't have to add your library to mypy ignore list :)
references.
https://peps.python.org/pep-0561/#packaging-type-information
The text was updated successfully, but these errors were encountered: