Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report - UTF-8 Encoding #8

Open
jeremyharper opened this issue Jun 1, 2024 · 1 comment
Open

Bug Report - UTF-8 Encoding #8

jeremyharper opened this issue Jun 1, 2024 · 1 comment

Comments

@jeremyharper
Copy link

I'm not familiar with Git to submit a bug fix the right way, so I'm doing it here in case it helps someone else.

I kept getting error messages saying "unsupported charset UTF8." I dug into the file the error message said it was coming from, and discovered the script was checking for "UTF-8" and the request was coming with the charset listed as UTF8, without the dash.

I fixed it with this change: On line 128 of KoboOmnivoreConverter-main/node_modules/body-parser/lib/types/ change
if (charset.slice(0, 4) !== 'utf-') {
to
if (charset.slice(0, 3) !== 'utf') {

Now I'm getting articles on my e-reader!

@jeremyharper jeremyharper changed the title Bug Report - UTF-8 Enco Bug Report - UTF-8 Encoding Jun 1, 2024
@Podginator
Copy link
Owner

It's strange that I haven't seen this earlier. I'm going to take a look, it's not really feasible to modify the underlying package.

Give me a little while and I'll create a PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants