-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when running from a yarn script #6
Comments
Sure, create a pull request. Probably best to just use Never encountered this before, so good catch! |
So this is kinda weird... When I
But when I clone this repo I get:
Any ideas? Is there something happening when you publish the package? |
Sorry about the late reply. Yeah, that's really strange... Do you get the error:
when running from a yarn script? I'm using yarn |
I don't get that error, but I'll try and update yarn to your version and see if it happens. |
So, I updated yarn. Still not getting an error. Though I noticed that when installing with version node_modules/fauna-gql-upload/index.js: a /usr/bin/env node script, ASCII text executable, with CRLF line terminators The same as yours. So, that seems to be a difference across yarn versions. I can't seem to reproduce the error, either on windows or ubuntu. I'm using WSL, so I even tried Could you share a repo to reproduce the error? Even though changing the line endings solves it, I'd still like to know what the cause is. |
Very strange... I've found this issue: yarnpkg/yarn#5480 I'll investigate I bit further tomorrow and try to create a minimal reproduction. Will keep you posted. Thanks. |
@Plazide I can't figure this out... What do you think about adding the |
Sure, let's try that. Create the PR, I'll merge, and then publish a dev version on npm. |
@maxfi I added the |
Thanks for that @Plazide. 🙏 Unfortunately it didn't work though. 🤔 |
@Plazide any ideas how I can troubleshoot this? Thanks. |
@maxfi I really have no idea. Do you have the same problem with every version of the package? Or is it just the later versions? |
@maxfi I published another version yesterday, I changed some local git settings, specifically Hopefully, it will help. |
@Plazide Woohooo! It's working now with the latest version! 🥳 Thanks so much for getting it sorted! 🙏 |
With the following yarn script:
when running
yarn run fauna-gql-upload
the following error is produced:This is an issue with yarn.
Converting https://github.com/Plazide/fauna-gql-upload/blob/master/index.js#L1 to use Unix line endings (
LF
rather thanCRLF
) fixes the issue.I can create a pull request if you agree. Thanks.
The text was updated successfully, but these errors were encountered: