Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the flowchart #178

Closed
GallVp opened this issue Nov 6, 2024 · 0 comments · Fixed by #185
Closed

Update the flowchart #178

GallVp opened this issue Nov 6, 2024 · 0 comments · Fixed by #185
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@GallVp
Copy link
Member

GallVp commented Nov 6, 2024

Description of feature

Feedback from @jfy133

Slightly different style (more bendy/curve) but I like it, and pretty polished already!

  1. The 3D-DNA/visualise and assemblyation_status corners should be curved somehow rather than the hard right angle - it's a bit jarring currently (the amount of curve of the orange line might be sufficient for these two)
  2. I would increase the size of the station circles a bit, they are a bit too small/ratio to the lines is a bit off to my eyes
  3. The FASTA/TSV going to MUMmer Circos plot is a bit hard to infer if that's input or output (I'm presuming it's input?), it should be angled to indicate a right-to-left directionality if so (as in push the mid-point of the curve angle in the direction it's should be going so it's not the center of the black stop bar). Another option is to change (for all inputs) the bars to an arrow shape rather than the bar
  4. The black stop bars ratio is also a bit off, I would make them all a bit wider (except the final AssemblyQC HTML - that one looks fine to me)
@GallVp GallVp added the enhancement New feature or request label Nov 6, 2024
@GallVp GallVp added this to the 2.3.0 milestone Nov 6, 2024
@GallVp GallVp self-assigned this Nov 6, 2024
@GallVp GallVp removed their assignment Nov 21, 2024
@GallVp GallVp modified the milestones: 2.3.0, 2.2.1 Dec 11, 2024
@GallVp GallVp self-assigned this Dec 11, 2024
@GallVp GallVp linked a pull request Dec 11, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant