Specialize TfHashAppend
for std::vector<bool>
#2298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The
TfHashAppend
specialization forstd::vector
uses the.data()
method to hash contiguous elements. However,std::vector<bool>
is not guaranteed to provide a.data()
method and does not guarantee the underlying data's length is the container'ssize() * sizeof(bool)
.This change modifies the
TfHashAppend
specialization to not match againststd::vector<bool>
and provides a more explicit specialization that usesstd::hash
instead.This issue was detected during testing of #2176 which changes
VtHash
to preferTfHash
overhash_value
for hashing.Fixes Issue(s)
TfHash
toboost::hash
#2172