Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: append should be used for CMAKE_MODULE_PATH #2275

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

CraigHutchinson
Copy link
Contributor

@CraigHutchinson CraigHutchinson commented Feb 14, 2023

Description of Change(s)

CMAKE_MODULE_PATH is a directory list and shall be appended via list(APPEND

Note

No major change but ensures when CMAKE_MODULE_PATH has been defined with alternative defaults on the command-line or via use of CMAKE_PROJECT_TOP_LEVEL_INCLUDES

  • I have verified that all unit tests pass with the proposed changes
  • [x ] I have submitted a signed Contributor License Agreement

PR Note:

  • First commit to confirm CLA
  • This change is small enough and deemed self-explanatory to not affect tests, I will however look into executing tests as a sanity check soon but do not see this PR being blocked on this?

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-8013

@CraigHutchinson CraigHutchinson changed the base branch from dev to release February 27, 2023 15:07
@CraigHutchinson CraigHutchinson changed the base branch from release to dev February 27, 2023 15:07
@pixar-oss pixar-oss merged commit b97806d into PixarAnimationStudios:dev Mar 14, 2023
@CraigHutchinson CraigHutchinson deleted the patch-2 branch March 16, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants