Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[work] add missing include <algorithm> for std::max #2194

Merged

Conversation

pmolodo
Copy link
Contributor

@pmolodo pmolodo commented Jan 24, 2023

Description of Change(s)

was getting errors when building without python on windows VS2022 - I think python and the older boost version were both bringing in the header; without either, it errored.

Fixes Issue(s)

  • error with no-python VS2022 build - max not a member of std, due to missing header
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

was getting errors when building without python on windows VS2022 - I
think python and the older boost version were both bringing in the
<algorithm> header; without either, it errored.
@sunyab
Copy link
Contributor

sunyab commented Jan 27, 2023

Filed as internal issue #USD-7914

@pixar-oss pixar-oss merged commit e263a36 into PixarAnimationStudios:dev Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants