Replace boost hash usage with TfHash in pxr/usd/pcp #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2023
nvmkuruc
force-pushed
the
pcphash
branch
4 times, most recently
from
cb0f980 to
a0dc4d1
Compare
|
Filed as internal issue #USD-7906 |
nvmkuruc
force-pushed
the
pcphash
branch
2 times, most recently
from
2f823aa to
f62778d
Compare
nvmkuruc
force-pushed
the
pcphash
branch
3 times, most recently
from
86a0092 to
0468a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Requires #2173
To remove the dependency of pxr/usd/pcp on boost's hashing functions
PcpInstanceKeynow relies onTfHash's hashing of containers instead of its own iteration. To support this, the method_Arc::GetHashhas been replaced with aTfHashAppendoverloadPcpLayerStackIdentifier{,Str},PcpMapExpression,PcpSite{,Str}useTfHash::Combineinstead ofboost::hash_combinePcpInstanceKeyandPcpMapFunctionPcpMapFunction's hashing has been split off into an overload ofTfHashAppendfor its_Datawhich isTfHash::Combined with the hash of its_offsetfieldFixes Issue(s)
-#2172 (additional PRs forthcoming)