Fix bug in HdExtComputationUtils::_GenerateDependencyMap() with multiple input computations #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are multiple input computations. The last element in the queue was used instead of the front element that is subsequently popped from the queue, which caused some input computations to be skipped if the queue ever has multiple entries. Extended testHdExtComputationUtils to add code coverage for this by using multiple input computations (the skinning computation only has a single input aggregator computation, so it didn't encounter this bug).
|
Filed as internal issue #USD-7684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The last element in the queue was used instead of the front element that is subsequently popped from the queue, which caused some input computations to be skipped if the queue ever has multiple entries.
Extended testHdExtComputationUtils to add code coverage for this by using multiple input computations (the skinning computation only has a single input aggregator computation, so it didn't encounter this bug).