Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find opensubdiv condition check #2030

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

Danielmelody
Copy link
Contributor

Description of Change(s)

Cmake would define OPENSUBDIV_${UPPERCOMPONENT}_LIBRARY to OPENSUBDIV_${UPPERCOMPONENT}_LIBRARY-NOTFOUND if find opensubdiv failed, this variable is definded, but evals to false, so we should check the variable itself, not whether it is defined.
Ref: https://cmake.org/cmake/help/latest/command/find_library.html

Fixes Issue(s)

  • None
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7629

@sunyab sunyab changed the base branch from release to dev February 17, 2023 21:03
@pixar-oss pixar-oss merged commit 1859681 into PixarAnimationStudios:dev Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants