APPLE: Basis curves on Metal - Updated mega PR #2027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slingthor
changed the title
slingthor
force-pushed
the
thor/dev/basis_curve_metal
branch
from
884b7f6
to
07d6457
Compare
slingthor
force-pushed
the
thor/dev/basis_curve_metal
branch
from
07d6457
to
671eff5
Compare
|
Filed as internal issue #USD-7616 |
pixar-oss
pushed a commit
that referenced
this pull request
Apr 3, 2023
Updated curve basis coefficient and array initialization to use braced initializer list syntax since that is supported for both GLSL and MSL. Also, added some floating point literal suffixes to help with overload resolution for MSL. Contribution: Thor Hjalmarsson Fixes #2027 (Internal change: 2268985)
pixar-oss
pushed a commit
that referenced
this pull request
Apr 3, 2023
This updates Storm codeGen for PTCS to be more consistent with codeGen for PTVS. An additional simplification here is to remove the use of ptvs_pv staging values for vertex and varying primvar data. Now these are accessed directly from input attributes or varying data buffers similar to other kinds of shader stages. Contribution: Thor Hjalmarsson, David G Yu Fixes #2027 (Internal change: 2269369)
pixar-oss
pushed a commit
that referenced
this pull request
Apr 3, 2023
Implemented Storm support for the remaining refined drawing modes for basisCurves and mesh geometry for HgiMetal. Two significant differences with Metal tessellation are: 1) need to pre-compute a buffer of tessellation factors. 2) different attribute data access from PTVS vs VS/TCS. For 1) we introduce a PostTessellationControl (PTCS) shader which is a Metal PostTessellationVertex shader (PTVS) executed with rasterization disabled to compute and store values into a buffer of tessellation factors. For 2) we're able to handle most data access differences within Storm codeGen's accessor methods or within helper methods in the shader source. - Added HgiBindResourceTypeTessFactors to designate a buffer binding for the tessFactors buffer. - Updated HdSt_PipelineDrawBatch to allocate a tessFactors buffer and execute PTCS shaders. - Updated HgiMetal to bind the tessFactors buffer and execute PTCS shaders. - Updated Storm codeGen to support accessing varying data buffers indexed using values from the primitive index buffer. - Updated Storm basisCurves shader source and shaderKey to support both VS/TCS/TES and PTCS/PTVS pipelines with most shader source code shared in common between the two different kinds of pipelines. - Updated Storm mesh shader source and shaderKey to support PTCS/PTVS tessellation using OpenSubdiv surface evaluation. Contribution: Thor Hjalmarsson, David G Yu Fixes #2027 (Internal change: 2269604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Some of these changes are already split up and some are in flight of being merged in and changes from an earlier PR are already in to start supporting the PTCS stage - This one is a "mega PR" where everything can be looked at together and all latest feedback has been adhered to.
Incoming will be an updated split of the rest of the PTCS stage addition from this PR. With the outstanding changes to glslfx and shader function interface already split, that hopefully makes the change granular enough, to get it all in.
Fixes Issue(s)