fix: export targets for usd_ms correctly #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We were looking at this as well! Really would like to see this included |
|
Filed as internal issue #USD-7615 |
|
Thanks for the PR, this mostly looks good to us and in order to bring it in and test it, we require a CLA to be signed. It seems we do not have a CLA on record for you, could you please follow the instructions here: https://graphics.pixar.com/usd/release/contributing_to_usd.html#contributor-license-agreement? |
|
@tallytalwar |
|
It seems that my signed CLA has been accepted by Pixar, so this PR can be merged :) |
|
Yup, thanks @sssooonnnggg . Aiming to include it in our next dev branch push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Currently the pxrTargets.cmake for monolithic buid is missing, and pxrConfig.cmake is broken.
Fixes Issue(s)