[cmake] remove unused PXR_PYTHON_ENABLED and PXR_PYTHON_MODULES_ENABLED #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are compile definitions set by the _pxr_library cmake function; however, they are: - never used anywhere - set unconditionally (ie, regardless of PXR_ENABLE_PYTHON_SUPPORT) - unneeded, as c++ code can include `pxr.h`, and use `#ifdef PXR_PYTHON_SUPPORT_ENABLED`
|
Filed as internal issue #USD-7516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
these are compile definitions set by the _pxr_library cmake function;
however, they are:
never used anywhere
set unconditionally (ie, regardless of PXR_ENABLE_PYTHON_SUPPORT)
unneeded, as c++ code can include
pxr.h, and use#ifdef PXR_PYTHON_SUPPORT_ENABLEDI have submitted a signed Contributor License Agreement