Use SdfPathSet instead of StdPathVector for instancePaths in UsdImagingInstanceAdapter::_Populate #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er count of instances the runtime of std::vector::insert at 'random' positions can potentially go up to O(N^2) whereas std::set::insert runs with O(N log(N)). I have profilings of scenes with 1M instances where std::vector::insert takes ~100s of total time (25% load time) whereas times for std::set::insert are neglectable. Also when erasing an prototype avoid a copy by using std::swap to grab the data from the instancerData structure.
|
Filed as internal issue #USD-7305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
When having a high count of instances the runtime of std::vector::insert at 'random' positions in this function can potentially go up to O(N^2) whereas std::set::insert runs with O(N log(N)). I have profilings of scenes with 1M instances where std::vector::insert takes ~100s of total time (25% load time) whereas times for std::set::insert are mostly noise in the profiling.
Also when erasing an prototype avoid a copy by using std::swap to grab the data from the instancerData structure.
Fixes Issue(s)
[X ] I have submitted a signed Contributor License Agreement