Support shapes with blendshapes but no skinning when using the CPU computation #1757
Conversation
…mputation. Previously UsdSkelSkinPointsLBS() would be invoked with empty influences in this case, which would move all the points to the origin. There's no need to do any extra work if there are only blendshapes.
|
(Github's diff isn't aligned very well, but it's actually just a one line change + indentation shift if you view with whitespace disabled) |
|
Thank you @cameronwhite - we'll try to get this looked at soon! Could I ask you, though, to go as far as you can with a testcase? I think that could be as simple as a source usda file (e.g. your attached file) with an embedded camera that demonstrates the problematic scenario, added in a suitably named subdir of usdImagingGL/testenv ? We can take care of the rest of the harness... (and we're making progress on being able to publish the internal tests we have here, with NVidia's help) but having it be part of the PR will help! |
|
Sure! I'll take a look at adding a test there |
|
It looks like the existing test file for testUsdImagingGLSkelBlendShapes does exhibit the issue if it's run with the CPU computation ( |
|
Haha - thanks @cameronwhite ; rookie move I was looking at the release branch, where we hadn't yet published any of our tests! |
|
Filed as internal issue #USD-7173 |
Currently, a shape that has blendshapes but no skinning isn't visible when using the CPU ExtComputation, but the GPU version in Storm behaves okay.
To reproduce, load the attached file with
usdview blendshapes.usda --camera /cameras/camera1and use a delegate such as Embree, or setUSDSKELIMAGING_FORCE_CPU_COMPUTE=1in the environment to reproduce with Storm