collection of fixes for building without pre-compiled headers #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie, if -DPXR_ENABLE_PRECOMPILED_HEADERS=OFF wanted to build without precompiled headers to help with debugging a strange build issue (ie, create more transparent + atomic build steps) also, turning off PCH usage allows stashed.io (a caching compiler wrapper for MSVC) to operate when using PDB (see: https://github.com/playscale/stashed.io/wiki/PDB-and-PCH-generation) most fixes are pretty self-explanatory - adding some missing headers to individual source / header files in stackTrace.cpp, the include of Winsock2.h must happen before windows.h, which is brought in via fileSystem.h See: PixarAnimationStudios#1672
pmolodo
force-pushed
the
pr/no_pch_fixes
branch
from
ea5cfb4
to
445e3f8
Compare
|
Filed as internal issue #USD-7002 |
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
ie, if -DPXR_ENABLE_PRECOMPILED_HEADERS=OFF wanted to build without precompiled headers to help with debugging a strange build issue (ie, create more transparent + atomic build steps) also, turning off PCH usage allows stashed.io (a caching compiler wrapper for MSVC) to operate when using PDB (see: https://github.com/playscale/stashed.io/wiki/PDB-and-PCH-generation) most fixes are pretty self-explanatory - adding some missing headers to individual source / header files in stackTrace.cpp, the include of Winsock2.h must happen before windows.h, which is brought in via fileSystem.h See: PixarAnimationStudios#1672
buddly27
pushed a commit
to untwine/pxr-arch
that referenced
this pull request
Aug 20, 2023
ie, if -DPXR_ENABLE_PRECOMPILED_HEADERS=OFF wanted to build without precompiled headers to help with debugging a strange build issue (ie, create more transparent + atomic build steps) also, turning off PCH usage allows stashed.io (a caching compiler wrapper for MSVC) to operate when using PDB (see: https://github.com/playscale/stashed.io/wiki/PDB-and-PCH-generation) most fixes are pretty self-explanatory - adding some missing headers to individual source / header files in stackTrace.cpp, the include of Winsock2.h must happen before windows.h, which is brought in via fileSystem.h See: PixarAnimationStudios/OpenUSD#1672
buddly27
pushed a commit
to untwine/pxr-arch
that referenced
this pull request
Mar 24, 2024
ie, if -DPXR_ENABLE_PRECOMPILED_HEADERS=OFF wanted to build without precompiled headers to help with debugging a strange build issue (ie, create more transparent + atomic build steps) also, turning off PCH usage allows stashed.io (a caching compiler wrapper for MSVC) to operate when using PDB (see: https://github.com/playscale/stashed.io/wiki/PDB-and-PCH-generation) most fixes are pretty self-explanatory - adding some missing headers to individual source / header files in stackTrace.cpp, the include of Winsock2.h must happen before windows.h, which is brought in via fileSystem.h See: PixarAnimationStudios/OpenUSD#1672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
ie, if -DPXR_ENABLE_PRECOMPILED_HEADERS=OFF
wanted to build without precompiled headers to help with debugging a
strange build issue (ie, create more transparent + atomic build steps)
also, turning off PCH usage allows stashed.io (a
caching compiler wrapper for MSVC) to operate when using PDB
(see: https://github.com/playscale/stashed.io/wiki/PDB-and-PCH-generation)
most fixes are pretty self-explanatory - adding some missing headers to
individual source / header files
in stackTrace.cpp, the include of Winsock2.h must happen before windows.h,
which is brought in via fileSystem.h