Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hdSt] 'default' input of MaterialX geompropvalue node is ignored #1880

Closed
pablode opened this issue May 24, 2022 · 1 comment
Closed

[hdSt] 'default' input of MaterialX geompropvalue node is ignored #1880

pablode opened this issue May 24, 2022 · 1 comment

Comments

@pablode
Copy link
Contributor

pablode commented May 24, 2022

When a <geompropvalue> node tries to read a geomprop that does not exist, a hardcoded value of 0.0 is returned:
https://github.com/PixarAnimationStudios/USD/blob/3b097e3ba8fabf1777a1256e241ea15df83f3065/pxr/imaging/hdSt/materialXShaderGen.cpp#L677-L688

But the <geompropvalue> node has a default input, which should be returned instead (MaterialX 1.38 spec. p. 28 bottom).
@pablode pablode changed the title [hdSt] 'default' input of geompropvalue node is ignored [hdSt] 'default' input of MaterialX geompropvalue node is ignored May 24, 2022
@jilliene
Copy link

Filed as internal issue #USD-7386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pablode @jilliene