[arch] make testArchStackTrace work on windows debug even when relocated #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmolodo
force-pushed
the
pr/fix_windows_debug_testArchStackTrace
branch
from
89be574 to
86b3ab8
Compare
|
Filed as internal issue #USD-7359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
On windows, in debug mode, we need to copy testArchStaceTrace.pdb into the testing folder, so the test can find it (and print out the right stack), even if the build or test folder has been moved (ie, when the baked-in path in executable, where it also looks for the pdb, doesn't work)
Fixes Issue(s)
testArchStackTrace failed on windows debug if build folder was relocated
I have submitted a signed Contributor License Agreement