Autodesk: Remove the duplicate code in basisCurves.glslfx #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-9765 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fix alpha channel is missing in ShadingTerminal function of basisCurves.glslfx.
In change 56e3997, some common shading code are moved to terminals.glslfx. But he forgot to remove the corresponding snippets in BasisCurves.Fragment of BasisCurves.glslfx. And then in the following change, the removed snippets for Curves.Fragment.Wire is incorrectly returned back at change b3e6fee. In this change, we remove the redundant code in BasisCurves.glslfx, so that ApplyColorOverrides and LightBlending will not be twicely called.
Fixes Issue(s)