Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MaterialX material tag detection for glTF PBR #3069

Merged

Conversation

pablode
Copy link
Contributor

@pablode pablode commented May 5, 2024

Description of Change(s)

As described in the linked issue, MaterialX materials using the <gltf_pbr> with alpha blending currently render incorrectly:
AlphaBlendModeTest_before

This PR extends the detection heuristic to cover the inputs of the glTF PBR. The alpha blending is smooth:
AlphaBlendModeTest_after

Test asset: AlphaBlendModeTest_mtlx.zip

Fixes Issue(s)

#1882

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-9633

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit 09b58ad into PixarAnimationStudios:dev May 29, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants