Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make boost an optional dependency of OpenUSD #3028

Closed

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Apr 1, 2024

Description of Change(s)

This PR makes boost an optional dependency when not building with python, openvdb, or openimageio. This changes the build_usd script to explicitly create the lib directory with the correct permissions, as downstream builds (like tbb) expected this to have already been created by the boost step.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the makeboostoptional branch from a7e9b70 to 1657c17 Compare April 1, 2024 14:37
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-9507

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nvmkuruc nvmkuruc force-pushed the makeboostoptional branch from 1657c17 to 84b326c Compare April 23, 2024 21:32
@nvmkuruc
Copy link
Collaborator Author

This no longer depends on the PEGLT PR.

@nvmkuruc nvmkuruc force-pushed the makeboostoptional branch 2 times, most recently from 36a74e6 to c044897 Compare May 29, 2024 16:43
@nvmkuruc nvmkuruc marked this pull request as ready for review May 29, 2024 16:46
@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nvmkuruc nvmkuruc force-pushed the makeboostoptional branch from c044897 to af11acf Compare June 4, 2024 17:26
@nvmkuruc
Copy link
Collaborator Author

nvmkuruc commented Jun 4, 2024

Removed note about PCH files now that they've been updated by 5000b45

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

pixar-oss pushed a commit that referenced this pull request Jun 28, 2024
OpenUSD now only requires boost to build the optional Python bindings
or to support optional dependencies like OpenVDB.

build_usd.py now builds boost only if Python bindings, OpenVDB, or
OpenImageIO support is enabled.

This change builds off of PR #3028 from @nvmkuruc.

Fixes #3028

(Internal change: 2331606)
@nvmkuruc nvmkuruc closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants