-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make boost an optional dependency of OpenUSD #3028
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
force-pushed
the
makeboostoptional
branch
from
April 1, 2024 14:37
a7e9b70
to
1657c17
Compare
Filed as internal issue #USD-9507 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
nvmkuruc
force-pushed
the
makeboostoptional
branch
from
April 23, 2024 21:32
1657c17
to
84b326c
Compare
This no longer depends on the PEGLT PR. |
2 tasks
nvmkuruc
force-pushed
the
makeboostoptional
branch
2 times, most recently
from
May 29, 2024 16:43
36a74e6
to
c044897
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
nvmkuruc
force-pushed
the
makeboostoptional
branch
from
June 4, 2024 17:26
c044897
to
af11acf
Compare
Removed note about PCH files now that they've been updated by 5000b45 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
pixar-oss
pushed a commit
that referenced
this pull request
Jun 28, 2024
OpenUSD now only requires boost to build the optional Python bindings or to support optional dependencies like OpenVDB. build_usd.py now builds boost only if Python bindings, OpenVDB, or OpenImageIO support is enabled. This change builds off of PR #3028 from @nvmkuruc. Fixes #3028 (Internal change: 2331606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This PR makes
boost
an optional dependency when not building with python, openvdb, or openimageio. This changes thebuild_usd
script to explicitly create thelib
directory with the correct permissions, as downstream builds (liketbb
) expected this to have already been created by theboost
step.Fixes Issue(s)