Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require strict URI scheme validation for ArResolver #2997

Merged

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Mar 11, 2024

Description of Change(s)

#2453 validated URI schemes against the RFC 3986 and RFC 3987 specification by default. An environment variable could be set to make scheme validation more permissive. This change removes that environment variable, requiring all schemes identifiers to adhere to the specification.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-9414

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nvmkuruc nvmkuruc force-pushed the arrequirestrictvalidation branch from acf68fe to 67e63fc Compare March 15, 2024 19:27
@nvmkuruc nvmkuruc force-pushed the arrequirestrictvalidation branch from 67e63fc to 18bc45a Compare March 28, 2024 15:40
@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nvmkuruc nvmkuruc force-pushed the arrequirestrictvalidation branch from 18bc45a to c8309f6 Compare April 1, 2024 14:49
@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nvmkuruc nvmkuruc force-pushed the arrequirestrictvalidation branch from c8309f6 to 56848f2 Compare May 13, 2024 19:58
@nvmkuruc nvmkuruc force-pushed the arrequirestrictvalidation branch 2 times, most recently from 5d0bd32 to 49f1a6d Compare May 31, 2024 14:31
@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nvmkuruc nvmkuruc force-pushed the arrequirestrictvalidation branch from 49f1a6d to b9fdd32 Compare June 4, 2024 19:41
@nvmkuruc nvmkuruc force-pushed the arrequirestrictvalidation branch from b9fdd32 to f75d65a Compare June 12, 2024 14:10
@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit 0b7c06d into PixarAnimationStudios:dev Jun 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants