Make it safe for Pcp.NodeRef to refer to a null PcpNodeRef #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
false if the referenced PcpNodeRef cast to bool returns false. Override the implementation of __getattribute__ so that trying to call any method on a null PcpNodeRef raises a python exception (instead of crashing).
marktucker
changed the title
|
Filed as internal issue #USD-9289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Add a proper cast-to-bool operation to pxr.Pcp.NodeRef which returns false if the referenced PcpNodeRef cast to bool returns false. Override the implementation of getattribute so that trying to call any method on a null PcpNodeRef raises a python exception (instead of crashing).
Fixes Issue(s)
Crash when accessing a null PcpNodeRef object through python #2942
[ X ] I have verified that all unit tests pass with the proposed changes
[ X ] I have submitted a signed Contributor License Agreement