Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::intrusive_ptr with TfDelegatedCountPtr for Usd_PrimData #2897

Merged

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Dec 28, 2023

Description of Change(s)

(Depends on #2891)

#2891 provided a TfDelegatedCountPtr to support custom bookkeeping. This replaces the usage of boost::intrusive_ptr with TfDelegatedCountPtr in Usd_PrimData. As TfDelegatedCountPtr doesn't support implicit conversion from raw pointers, construction with explicit dispatch tags are now used.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the usdprimdataintrusiveptr branch from ba310c6 to b9e4c01 Compare December 28, 2023 23:11
@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-9128

@nvmkuruc nvmkuruc force-pushed the usdprimdataintrusiveptr branch from b9e4c01 to b230f81 Compare January 3, 2024 23:07
@nvmkuruc nvmkuruc force-pushed the usdprimdataintrusiveptr branch from b230f81 to 70fefc9 Compare January 22, 2024 21:46
@nvmkuruc nvmkuruc changed the title Replace boost::intrusive_ptr with TfIntrusiveTrackingPtr for Usd_PrimData Replace boost::intrusive_ptr with TfDelegatedCountPtr for Usd_PrimData Jan 22, 2024
@nvmkuruc nvmkuruc force-pushed the usdprimdataintrusiveptr branch 4 times, most recently from 85a3775 to 0819948 Compare January 23, 2024 14:46
@nvmkuruc nvmkuruc force-pushed the usdprimdataintrusiveptr branch 2 times, most recently from 5c4c8ad to 2ba3533 Compare February 1, 2024 19:32
@nvmkuruc nvmkuruc force-pushed the usdprimdataintrusiveptr branch 5 times, most recently from e4aee6e to 40ce1c7 Compare February 12, 2024 16:15
@nvmkuruc nvmkuruc force-pushed the usdprimdataintrusiveptr branch from 40ce1c7 to 0b4e5ad Compare March 1, 2024 15:33
@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit e2cddaa into PixarAnimationStudios:dev Mar 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants