Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::intrusive_ptr with TfDelegatedCountPtr in Usd_CrateFile #2895

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Dec 28, 2023

Description of Change(s)

(Depends on #2891)

#2891 provided a TfDelegatedCountPtr to support custom bookkeeping. This replaces the usage of boost::intrusive_ptr with TfDelegatedCountPtr in Usd_CrateFile.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the usdcrateintrusiveptr branch from d8222ee to 8332df8 Compare December 28, 2023 23:12
@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-9126

@nvmkuruc nvmkuruc force-pushed the usdcrateintrusiveptr branch 2 times, most recently from 3cb3f78 to 1343cbf Compare January 6, 2024 20:51
@nvmkuruc nvmkuruc force-pushed the usdcrateintrusiveptr branch from 1343cbf to addce5e Compare January 22, 2024 21:34
@nvmkuruc nvmkuruc changed the title Replace boost::intrusive_ptr with TfIntrusiveTrackingPtr in Usd_CrateFile Replace boost::intrusive_ptr with TfDelegatedCountPtr in Usd_CrateFile Jan 22, 2024
@nvmkuruc nvmkuruc force-pushed the usdcrateintrusiveptr branch 2 times, most recently from 39cbf6f to 0491a61 Compare January 23, 2024 14:38
@nvmkuruc nvmkuruc force-pushed the usdcrateintrusiveptr branch 2 times, most recently from 6e56b1f to 7240528 Compare February 8, 2024 21:46
@nvmkuruc nvmkuruc force-pushed the usdcrateintrusiveptr branch 5 times, most recently from e4998a0 to 06429b2 Compare February 12, 2024 16:14
@nvmkuruc nvmkuruc force-pushed the usdcrateintrusiveptr branch from 06429b2 to bdac6be Compare March 1, 2024 15:33
@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit ffdea76 into PixarAnimationStudios:dev Mar 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants