Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert xid ranges classes into compile time lookup tables #2857

Conversation

erslavin
Copy link
Contributor

Description of Change(s)

This change converts the original TfStaticData based Unicode XidStart / XidContinue ranges into compile time lookup tables through the use of constexpr in order to minimize the initialization overhead of creating these ranges (and associated flag data) on startup.
 

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@erslavin erslavin force-pushed the unicode_character_classes_compile_time_ranges branch 2 times, most recently from 6da6e19 to 1c74d1c Compare December 11, 2023 22:58
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-9068

@erslavin erslavin force-pushed the unicode_character_classes_compile_time_ranges branch from 1c74d1c to 279542b Compare December 12, 2023 15:02
@pixar-oss pixar-oss merged commit c171f21 into PixarAnimationStudios:dev Dec 15, 2023
3 of 5 checks passed
@sunyab sunyab added the usd-utf8-identifiers Issues/PRs for Unicode Identifiers in USD proposal label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usd-utf8-identifiers Issues/PRs for Unicode Identifiers in USD proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants